Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucead Bid Adapter: Update #11488

Merged
merged 8 commits into from
May 28, 2024
Merged

Lucead Bid Adapter: Update #11488

merged 8 commits into from
May 28, 2024

Conversation

aymeric45
Copy link
Contributor

@aymeric45 aymeric45 commented May 14, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

  • Support Single Request Architecture mode
  • Enhanced reporting
  • Updated PAAPI auction config
  • Added region parameter

Other information

Docs update PR: prebid/prebid.github.io#5319

modules/luceadBidAdapter.js Outdated Show resolved Hide resolved
@aymeric45
Copy link
Contributor Author

aymeric45 commented May 14, 2024

Hello @patmmccann
Thanks for your feedback.
We are currently using the feature described here https://github.com/prebid/prebid-js-external-js-template and are fully compliant with the policy.
The source code can be audited here : https://github.com/lucead/prebid-js-external-js-lucead/tree/master/src
The build process can be found here: https://github.com/lucead/prebid-js-external-js-lucead/blob/master/package.json
Are there changes to be made to be compliant with PB9 while still using loadExternalScript ?

@ChrisHuie
Copy link
Collaborator

Doesn't appear you are passing schain. Please add as all adapters are now expected to support schain.

@patmmccann
Copy link
Collaborator

@aymeric45 you will not be able to import this function in Prebid 9. The prebid board of directors was very clear with me to sort this out by prebid 9 in a board meeting last year. Bidders are no longer permitted sidecar scripts.

I read your script and it appears to make client side endpoint calls to a bunch of prominent prebid ssps and interact with local storage in a way that bypasses activity controls. Neither of these activities would be allowed in your source code and are also not allowed in your sidecar script. Please remove it or risk unplanned changes to your adapter.

modules/luceadRtdProvider.js Outdated Show resolved Hide resolved
@patmmccann patmmccann merged commit 0f91aff into prebid:master May 28, 2024
2 of 3 checks passed
zkosanovic pushed a commit to OpenWeb-Public/Prebid.js that referenced this pull request May 29, 2024
* Lucead Bid Adapter: Support Single Request Architecture mode + enhanced reporting + updated PAAPI auction config

* PB9 compliance

* Added TCF Global Vendor List ID

* Add GVLID to Lucead RTD Provider

* Add domain in impression tracking

* remove RTD related files

* remove useless code

* remove lucead from adloader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants