Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteo Bid Adapter: converted adapter to oRTB 2.5 #11486

Merged
merged 1 commit into from
May 21, 2024

Conversation

Ticki84
Copy link

@Ticki84 Ticki84 commented May 14, 2024

Type of change

  • Updated bidder adapter

Description of change

  • Modified request and response models to comply with OpenRTB 2.5 (using the oRTB converter).
  • Changed the endpoint to forward requests to a new oRTB 2.5 compliant endpoint.
  • Dropped support of undefined sized banner trick in favor of built-in native media type.
  • Dropped support of native callback in favor of built-in rendering fn.

Breaking changes and how to migrate (for publishers)

  • If you were using undefined sized banner to get native bids:

    • Remove the undefined sized banner from mediaTypes.
    • Define a native object in mediaTypes.
  • If you were previously using a native callback:

Additional notes

Even though native requests without asset requirements should be supported, we strongly advised to define some native asset requirements.

modules/criteoBidAdapter.js Outdated Show resolved Hide resolved
modules/criteoBidAdapter.js Outdated Show resolved Hide resolved
modules/criteoBidAdapter.js Outdated Show resolved Hide resolved
@Ticki84
Copy link
Author

Ticki84 commented May 15, 2024

Pushed a change to use the 2.5 translator instead of moving each field "manually".
Huge thanks for the review @dgirardi !

@Ticki84
Copy link
Author

Ticki84 commented May 15, 2024

Pushed another change because gdprversion is still an extension field in 2.6.

modules/criteoBidAdapter.js Outdated Show resolved Hide resolved
modules/criteoBidAdapter.js Outdated Show resolved Hide resolved
modules/criteoBidAdapter.js Outdated Show resolved Hide resolved
@Ticki84 Ticki84 force-pushed the prebid9-ortb branch 2 times, most recently from 70b3c67 to e23e373 Compare May 16, 2024 12:31
@Ticki84
Copy link
Author

Ticki84 commented May 16, 2024

CI seems a bit flakky @dgirardi , let me know if I need to push another empty commit to retrigger the CI.

@ChrisHuie ChrisHuie merged commit 8559070 into prebid:9.0 May 21, 2024
2 checks passed
zkosanovic pushed a commit to OpenWeb-Public/Prebid.js that referenced this pull request May 29, 2024
Co-authored-by: f.caspar <f.caspar@criteo.com>
@patmmccann patmmccann mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants