Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insticator Bid Adapter: Add support for BidFloors #11472

Conversation

shubhamc-ins
Copy link
Contributor

@shubhamc-ins shubhamc-ins commented May 9, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@muuki88
Copy link
Collaborator

muuki88 commented May 10, 2024

Docs PR: prebid/prebid.github.io#5307

@shubhamc-ins shubhamc-ins requested a review from muuki88 May 10, 2024 10:47
@shubhamc-ins
Copy link
Contributor Author

Docs PR: prebid/prebid.github.io#5307

@muuki88 As I updated the logic in this PR. I think we don't need any changes in the Docs PR. Let me know what do you think.

modules/insticatorBidAdapter.js Outdated Show resolved Hide resolved
modules/insticatorBidAdapter.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates, looks good!

@ncolletti ncolletti merged commit dd34052 into prebid:master May 24, 2024
4 checks passed
@ncolletti ncolletti removed the request for review from muuki88 May 24, 2024 00:18
zkosanovic pushed a commit to OpenWeb-Public/Prebid.js that referenced this pull request May 28, 2024
* support bidfloor from params

* update test case for bidder bidfloor

* prioritize module floor

* fix

* update bidfloorcur

* add USD currency for module floor

* add test cases for bidfloors and fix module floor scopes

* add logwarn for non usd floors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants