Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driftpixel Bid Adapter : initial release #11454

Merged
merged 4 commits into from
May 20, 2024
Merged

Driftpixel Bid Adapter : initial release #11454

merged 4 commits into from
May 20, 2024

Conversation

driftpixelai
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

[
    {
        code: 'test-banner',
        mediaTypes: {
            banner: {
                sizes: [[300, 250]],
            }
        },
        bids: [
            {
                bidder: 'driftpixel',
                params: {
                    env: 'driftpixel',
                    pid: '40',
                    ext: {}
                }
            }
        ]
    },
    {
        code: 'test-video',
        sizes: [ [ 640, 480 ] ],
        mediaTypes: {
            video: {
                playerSize: [640, 480],
                context: 'instream',
                skipppable: true
            }
        },
        bids: [{
            bidder: 'driftpixel',
            params: {
                env: 'driftpixel',
                pid: '40',
                ext: {}
            }
        }]
    }
];

Other information

Docs PR: prebid/prebid.github.io#5302

@driftpixelai driftpixelai changed the title add driftpixel Adapter Driftpixel: new adapter May 7, 2024
@ChrisHuie ChrisHuie changed the title Driftpixel: new adapter Driftpixel Bid Adapter : initial release May 7, 2024
@ChrisHuie ChrisHuie requested a review from JulieLorin May 7, 2024 15:05
JulieLorin
JulieLorin reviewed May 10, 2024
View reviewed changes
modules/driftpixelBidAdapter.js Outdated

serverResponse.body.data.forEach(serverBid => {
const bid = {
requestId: bidderRequest.bidId,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incorrect to me : the bidderRequest.bidId field doesn't exist, but there is bidderRequest.bids[x].bidId (in the bids array), can you double check

test/spec/modules/driftpixelBidAdapter_spec.js Outdated
}
};

const validResponse = spec.interpretResponse(serverResponse, {bidderRequest: defaultRequest});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the format of the bidderRequest is not what will be present with a real bid (this is linked to the first comment)

JulieLorin
JulieLorin approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@JulieLorin JulieLorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie ChrisHuie merged commit 581a0ba into prebid:master May 20, 2024
2 of 3 checks passed
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request May 21, 2024
@driftpixelai @mefjush
Driftpixel Bid Adapter : initial release (prebid#11454)
582d863 
* add driftpixel Adapter

* fix warnings

* fix find requestId in interpretResponse

* fix format of the bidderRequest

---------

Co-authored-by: Chucky-choo <dedafu47@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulieLorin JulieLorin JulieLorin approved these changes

Assignees

@JulieLorin JulieLorin

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@driftpixelai @JulieLorin @ChrisHuie