Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveIntent Identity Module: Introduce First Party ID #11437

Merged
merged 7 commits into from
May 23, 2024

Conversation

3link
Copy link
Contributor

@3link 3link commented May 3, 2024

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

LiveIntent user ID module will be able to expose first party identifiers as fpid. In the current stage, fpid is read from either cookie jar or local storage depending in the configuration. In a future release, it can be populated from the LI user id module cookie.

Configuration to enable fpid:

"params": {
    "fpid": {
      "strategy": "cookie", // or 'html5'
      "name": "foobar"
    },
    "requestedAttributesOverrides": {'fpid': true}
}

Other information

@3link 3link force-pushed the fpid branch 2 times, most recently from 0e8affa to 5224b3e Compare May 3, 2024 11:30
@3link 3link force-pushed the fpid branch 2 times, most recently from dec60e7 to bf5debf Compare May 3, 2024 14:40
@mschuwalow mschuwalow force-pushed the fpid branch 2 times, most recently from 4e318e1 to ee14798 Compare May 7, 2024 01:04
@smenzer
Copy link
Collaborator

smenzer commented May 9, 2024

this generally looks ok to me. @SKOCHERI can you confirm the changes to package-lock.json are acceptable?

@3link
Copy link
Contributor Author

3link commented May 21, 2024

@SKOCHERI Can you please have a look at this PR?

@ChrisHuie
Copy link
Collaborator

this generally looks ok to me. @SKOCHERI can you confirm the changes to package-lock.json are acceptable?

The package-lock and package file changes seem fine to me.

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ncolletti ncolletti merged commit e074512 into prebid:master May 23, 2024
4 checks passed
Copy link

@premesh premesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused . I thought the intent was to remove the dependency on a 3rd party which is currently not allowed by any module today. This PR updates the dependency to new version of that 3rd party module ?

zkosanovic pushed a commit to OpenWeb-Public/Prebid.js that referenced this pull request May 28, 2024
* fpid

* lint

* Adjust tests

* Fix test expectation

* live-connect v6.7.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants