Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak package exports #503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tweak package exports #503

wants to merge 1 commit into from

Conversation

developit
Copy link
Member

Fix usage in Jest, drop *.module.js for just .mjs (files were nearly identical), don't include "browser" export map key, do include "module" export map key (to avoid dual package hazard).

…identical), don't include `"browser"` export map key, do include `"module"` export map key (to avoid dual package hazard).
Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: 85ce232

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 85ce232
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/65b4250f38180e00099082df
😎 Deploy Preview https://deploy-preview-503--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Size Change: -4.62 kB (-6%) ✅

Total Size: 76.3 kB

Filename Size Change
docs/dist/assets/client.********.js 46.3 kB -4 B (0%)
docs/dist/assets/index.********.js 830 B -245 B (-23%) 🎉
docs/dist/assets/signals-core.module.********.js 0 B -1.46 kB (removed) 🏆
docs/dist/assets/signals.module.********.js 0 B -2.02 kB (removed) 🏆
docs/dist/basic-********.js 240 B -4 B (-2%)
docs/dist/demos-********.js 3.41 kB +2 B (0%)
docs/dist/nesting-********.js 1.13 kB -2 B (0%)
docs/dist/react-********.js 236 B -6 B (-2%)
packages/core/dist/signals-core.mjs 1.55 kB -11 B (-1%)
packages/react-transform/dist/signals-transform.mjs 4.68 kB +673 B (+17%) ⚠️
packages/react-transform/dist/signals-transform.umd.js 0 B -4.87 kB (removed) 🏆
packages/react/dist/signals.mjs 0 B -150 B (removed) 🏆
docs/dist/assets/signals-core.********.js 1.46 kB +1.46 kB (new file) 🆕
docs/dist/assets/signals.********.js 2.02 kB +2.02 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
docs/dist/assets/jsxRuntime.module.********.js 281 B
docs/dist/assets/preact.module.********.js 4.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
packages/core/dist/signals-core.js 1.54 kB
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB
packages/react-transform/dist/signals-*********.js 4.76 kB
packages/react/dist/signals.js 189 B

compressed-size-action

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New major or sneak it into a minor?

@@ -4,7 +4,7 @@
"scripts": {
"prebuild": "rimraf packages/core/dist/ packages/preact/dist",
"build": "pnpm build:core && pnpm build:preact && pnpm build:react-runtime && pnpm build:react-auto && pnpm build:react && pnpm build:react-transform",
"_build": "microbundle --raw --globals @preact/signals-core=preactSignalsCore,preact/hooks=preactHooks,@preact/signals-react/runtime=reactSignalsRuntime",
"_build": "microbundle --format esm,cjs --raw --globals @preact/signals-core=preactSignalsCore,preact/hooks=preactHooks,@preact/signals-react/runtime=reactSignalsRuntime",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_build": "microbundle --format esm,cjs --raw --globals @preact/signals-core=preactSignalsCore,preact/hooks=preactHooks,@preact/signals-react/runtime=reactSignalsRuntime",
"_build": "microbundle --format esm,cjs,umd --raw --globals @preact/signals-core=preactSignalsCore,preact/hooks=preactHooks,@preact/signals-react/runtime=reactSignalsRuntime",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants