Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reverse recommendation for controlled inputs #1089

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rschristian
Copy link
Member

Reverses the recommendation for uncontrolled components over controlled, which I think everyone's in agreement with?

Do we want to also make a note of the issues that exist for controlled inputs in X?

@JoviDeCroock
Copy link
Member

Controlled components don't really exist in Preact, issues are things where you bail out of rendering resulting in the same value.

@rschristian
Copy link
Member Author

rschristian commented Mar 28, 2024

That was sorta my point, though I was trying to be a tad less bleak.

Do we want to out-right say they're unsupported? Problem is that a fair number of React folks expect that as a table-stakes feature, and for certain use cases (or if you squint hard enough at others), Preact can get the job done.

I just worry that being that up front about it might scare people away unnecessarily.

Edit: That being said, I'm happy to alter this to whatever. Just my 2 cents.

@JoviDeCroock
Copy link
Member

Yes, no I agree with you. I guess we could be upfront about returning to the same input and how to work around that (i.e. use an object-state or what's said here at the end)

@rschristian
Copy link
Member Author

I think that's reasonable.

Alrighty, I'll work on rewording this block entirely, get a bit more actionable info in here.

@rschristian rschristian marked this pull request as draft March 28, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants