Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add remark to additional modifiers #362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

donkeyDau
Copy link

Information taken from #62

@amiller-gh
Copy link

Looks like the package doesn't support all of the remark modifier, just * ? and +:

flags = (route[i].match(/[+*?]+$/) || EMPTY)[0] || '',

Would love to see full support though! Especially for unnamed path segments (ex: /foo(/bar)). Would help tremendously with matching default routes. @developit, interested in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants