Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip prop-passing if route is a DOM element (fixes #226) #231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

developit
Copy link
Member

@developit developit commented Sep 8, 2017

This fixes the following issue:

let div = render(
  <Router url="/?matches=hello">
    <div />
  </Router>
);

div.matches  // "hello" - should be DOM match() method

@developit
Copy link
Member Author

Note to self: tests need to be updated to only use components as children, and to test that elements as children do not receive router props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant