Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce github actions workflows #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sventschui
Copy link
Member

This introduces two workflows. Open for feedback and improvements.

push.yml

A regular CI build that runs tests.

Todo

  • Test coverage

release-publish.yml

Triggers when a release is published on github. It runs npm version <tag-name> and attaches the npm package tarball to the release. It then pushes the commit created by npm version and force pushes the release tag to the same commit.

  • It currently can not run npm publish preact packages require 2FA for publishing
  • It will fail and not update the branch/commit when there were commits added to the referenced branch in the meantime (kinda "expected behaviour")
  • It will fail if the release was not created on a branch but rather a commit (SHA)

@developit
Copy link
Member

developit commented May 29, 2020

@sventschui I've added {{ secrets.PREACT_NPM_TOKEN }} with the appropriate permissions.

@sventschui
Copy link
Member Author

sventschui commented Jun 2, 2020

Awesome 🥳 Only thing left then is how to handle the protected branches as pointed out by @marvinhagemeister. I guess it would be best to adjust the workflow to create a PR and then do the release on PR merge.

I‘ll try to dig into this during the following days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants