Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mirrors-pytest to all-repos.yaml #960

Closed
wants to merge 1 commit into from

Conversation

Repiteo
Copy link

@Repiteo Repiteo commented May 5, 2024

my new repository:

  • is added to the bottom or with existing repos from the same account
  • contains a license
  • is not language: system, language: script, language: docker, or language: docker_image
  • does not contain "pre-commit" in the name

@asottile
Copy link
Member

asottile commented May 5, 2024

pytest should not be run with pre-commit

@asottile asottile closed this May 5, 2024
@Repiteo
Copy link
Author

Repiteo commented May 5, 2024

Damn, couldn't have chosen a more qualified person to shoot this idea down lmao

@asottile
Copy link
Member

asottile commented May 5, 2024

there's a lot of writing about this amongst the pre-commit and pytest issue tracker(s) -- here's a short summary: pre-commit/pre-commit-hooks#291 (comment)

@Repiteo
Copy link
Author

Repiteo commented May 5, 2024

D'oh! I only checked the PRs for pytest, somehow didn't think to check issues as well. At least my specific use-case is rather small so I can get away with using it for the time being, but I can certainly see why you wouldn't want to "endorse" this practice by adding it officially.

@Repiteo Repiteo deleted the pytest branch May 6, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants