Skip to content

Commit

Permalink
Make user mode networking default for dev build
Browse files Browse the repository at this point in the history
As of now we support system mode and user mode networking for all platform and in
windows/mac user mode is default for releases and system mode for dev builds. This
create bit confusion and also dev forget to test what is going to delivered with release
so this PR will make it default for both release and dev side.
  • Loading branch information
praveenkumar committed Mar 21, 2022
1 parent 73bec3d commit aa7e94f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/crc/config/settings.go
Expand Up @@ -2,6 +2,7 @@ package config

import (
"fmt"
"runtime"

"github.com/code-ready/crc/pkg/crc/constants"
"github.com/code-ready/crc/pkg/crc/network"
Expand Down Expand Up @@ -119,7 +120,7 @@ func GetPreset(config Storage) preset.Preset {
}

func defaultNetworkMode() network.Mode {
if version.IsInstaller() {
if runtime.GOOS != "linux" {
return network.UserNetworkingMode
}
return network.SystemNetworkingMode
Expand Down

0 comments on commit aa7e94f

Please sign in to comment.