This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Add oauth redirect listener #634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an HTTP listener for use as the redirect_uri. This will allow gdrive to work after google phases out the "oob" redirect. Also implement oauth PKCE (code challenge) Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
The redirect_uri is where the google server redirects after completing authentication. From our perspective, it's a callback, not a redirect. Our authorize uri redirects to google, so it would be confusing to refer to the other url as a redirect Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
The vendored oauth2 module doesn't support extra token exchange args. As that is how PKCE is implemented, remove it Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
fix issue introduced in backport from msfjarvis branch; refer to ClientId and ClientSecret constants instead of (absent) parameters Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
cg2v
force-pushed
the
oauth_listener_upstream
branch
from
5bf9328
to
b6d4d53
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an HTTP listener for use as the redirect_uri. This will allow gdrive to work after google phases out the "oob" redirect.
I did have working OAuth PKCE (code challenge) support, but it does not work with the currently vendored oauth library, so it's dropped from this branch.