Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Peer Dependencies for React #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: update Peer Dependencies for React #125

wants to merge 1 commit into from

Conversation

feddyups
Copy link

@feddyups feddyups commented Jun 9, 2021

Update Peer Dependencies for React

@feddyups
Update Peer Dependencies for React
9c49a58 
Update Peer Dependencies for React
e0ne
e0ne approved these changes Jun 9, 2021
View reviewed changes
Copy link

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good to release with this change

@feddyups feddyups changed the title Update Peer Dependencies for React chore: update Peer Dependencies for React Jun 10, 2021
@schmave
Copy link

schmave commented Jun 23, 2021

Tests pass locally when using React 17, though you have to install @wojtekmaj/enzyme-adapter-react-17 as an enzyme adapter in order to get them to work. (Enzyme doesn't yet officially support React 17).

@yeikel
Copy link

yeikel commented Oct 18, 2021

Hi team,

What is blocking this change?

@kad-stokkt
Copy link

kad-stokkt commented Nov 18, 2021 •
edited

approval as a subtle nudge ;)

@iamursky
Copy link

up

@feddyups
Copy link
Author

Is this project still alive? Should we try with a fork or something? Ideally before we move to React 18?

@plamenkoyovchev
Copy link

Come on guys! Let's merge this thing :) A lot of people need it.

@stsmurf
Copy link

stsmurf commented Feb 2, 2022

+1

@iamursky
Copy link

+1

@nimesulide
Copy link

@praneshr could you please merge this PR?

@guy-har guy-har mentioned this pull request Jun 9, 2022
Closed
@nagarciah
Copy link

Hello @praneshr . I've been using this library with React 17 for months now and I can confirm it works fine. I would be glad to help you if there is still anything missing to merge this PR. How may I help?

@nnikitos95
Copy link

Hi, guys, what about merge and closing this issue?

@talSofer
Copy link

Hi, any estimation on when this issue will be resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e0ne e0ne e0ne approved these changes

@garyantoriano garyantoriano garyantoriano approved these changes

@nimesulide nimesulide nimesulide approved these changes

@michael1997 michael1997 michael1997 approved these changes

@CruseCtrl CruseCtrl CruseCtrl approved these changes

@Allwithyou999 Allwithyou999 Allwithyou999 approved these changes

@iamursky iamursky iamursky approved these changes

@mathgeek12 mathgeek12 mathgeek12 approved these changes

@KitaharaMugiro KitaharaMugiro KitaharaMugiro approved these changes

@kad-stokkt kad-stokkt kad-stokkt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet