Fix scroll lock issue for iOS #477
Conversation
|
BTW, the scroll lock issue sometimes actually caused by #470, since the "close modal" behavior doesn't triggered properly by the animation end event. So to test if the scroll lock issue is fixed, make sure |
| @@ -187,7 +188,7 @@ export const Modal = ({ | |||
| useModalManager(refModal, open); | |||
|
|
|||
| // Hook used to manage the scroll | |||
| useScrollLock(refModal, open, showPortal, blockScroll); | |||
| useScrollLock(refModalContainer, open, showPortal, blockScroll); | |||
There was a problem hiding this comment.
I don't really understand this change, you are passing refModalContainer instead of refModal, but on line 307 you actually changed the name, so it means you are passing the exact same value as before. I don't get how this can fix the problem?
There was a problem hiding this comment.
I see. The scroll lock somehow get fixed on my site, and probably not relating to this commit.
I'll look into it again.
I'll close the PR for now.
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 97.20% 97.22% +0.01%
==========================================
Files 6 6
Lines 179 180 +1
Branches 66 65 -1
==========================================
+ Hits 174 175 +1
Misses 5 5
Continue to review full report at Codecov.
|
Sorry for the late PR.
As I mentioned in #462, I end up using a new ref for modal container for
body-scroll-lockto address the issue.And I'm already using this build in production e-commerce site.
Related issues: #462, #468