Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete xmlns prop from svg close icon #429

Merged
merged 3 commits into from Nov 14, 2020
Merged

chore: delete xmlns prop from svg close icon #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ee66bc
Delete not neccessary line
RahulArt420 Oct 1, 2020
d4dd52e
Merge branch 'master' into pr/429
pradel Nov 14, 2020
6c3a500
fix tests
pradel Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion react-responsive-modal/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Expand Up @@ -10,7 +10,6 @@ exports[`modal closeIcon should render the closeIcon by default 1`] = `
height="28"
viewBox="0 0 36 36"
width="28"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M28.5 9.62L26.38 7.5 18 15.88 9.62 7.5 7.5 9.62 15.88 18 7.5 26.38l2.12 2.12L18 20.12l8.38 8.38 2.12-2.12L20.12 18z"
Expand Down
1 change: 0 additions & 1 deletion react-responsive-modal/src/CloseIcon.tsx
View file
Open in desktop
Expand Up @@ -39,7 +39,6 @@ const CloseIcon = ({
<svg
className={classNames?.closeIcon}
style={styles?.closeIcon}
xmlns="http://www.w3.org/2000/svg"
width={28}
height={28}
viewBox="0 0 36 36"
Expand Down