Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New beatmapset info page #7899

Draft
wants to merge 255 commits into
base: master
Choose a base branch
from
Draft

New beatmapset info page #7899

wants to merge 255 commits into from

Conversation

gagahpangeran
Copy link
Contributor

@gagahpangeran gagahpangeran commented Jul 20, 2021 •
edited by nanaya

Closes #7828

Depends on:

Known issues:

  1. missing spotlight marker
  2. missing featured artist marker
  3. redundant difficulty play count (part of success rate and buttons area)
  4. redundant mapper name (below title, detail section, next to difficulty name)
  5. missing favorite list
  6. missing where to put the download disable notice
  7. missing play fail/exit chart
  8. download button design needs improvement, especially the with/without video label
  9. tags popup
  10. rating/success rate display on non-ranked maps?

@gagahpangeran
change cover height
804cbb0
@gagahpangeran
rename file to header
adfbf0c
@gagahpangeran
add beatmap status
558a271
@gagahpangeran
add title, artist, and creator details
1489579
@gagahpangeran
add beatmap picker
452cf01
@gagahpangeran
initial beatmapset info
47b7b9a
@gagahpangeran
add star difficulty
7639cf7
@gagahpangeran
change to flex
e826cb2
@gagahpangeran
add beatmap icon in diff details
3d10aba
@gagahpangeran
add length and bpm
add4c3a
@gagahpangeran
fix some spacing
d39a93a
@gagahpangeran
add preview button
21165f4
@gagahpangeran
rename profile-page-toggle to page-toggle for reusability
b43d80b
@gagahpangeran
add simple cover toggle
8d905ef
@gagahpangeran
add beatmapset cover expanded to user profile customization
77517ee
@gagahpangeran
change cover height when expand and collapse
8719afc
@gagahpangeran
fix item class name
29fc2a5
@gagahpangeran
add beatmap icon
498c4dc
@gagahpangeran
replace and delete beatmap list file
bf5a316
@gagahpangeran
remove unused props
621e7bc
@gagahpangeran
initial new beatmapset header
8ec2e3a
@gagahpangeran
add type in beatmap list
fd02458
@gagahpangeran
add icon only for beatmap list item
31da25a
@gagahpangeran
add beatmap list icon only in beatmapset header
7aa3024
@gagahpangeran
change beatmap when clicked
66fbadd
@gagahpangeran
show title in beatmap picker
f7eb8c7
@gagahpangeran
hide icon title in beatmapset info
cde7d96
@gagahpangeran
change position a bit
5f98bc0
@gagahpangeran
initial beatmapset stats
739c84e
@gagahpangeran
add beatmapset metadata box
1f63a22
@nanaya
Remove leftover from old changes which made obsolete by the other PR
2594ba5
@nanaya
Merge branch 'ts-hype' into new-beatmap-page
3637280
@nanaya
Merge branch 'ts-beatmapset-main-2' into new-beatmap-page
a61ac0f
@nanaya
Remove unused props
8273e36
@nanaya
Group beatmap colour stripes
89239a4
@nanaya
Merge branch 'ts-beatmapset-main-2' into new-beatmap-page
52fea2a
@nanaya
Merge remote-tracking branch 'origin/master' into new-beatmap-page
49bf4d5
@nanaya
Lint fix
327e312
@nanaya
Fix beatmap list popup
07c2696
@nanaya
Merge remote-tracking branch 'origin/master' into new-beatmap-page
6c0eb9d
@nanaya
Adjust toolbar styling
06c2b9f 
Mainly removing the thick border (incorrect design).
@nanaya
mobx observable component shouldn't be pure
5d9278e
@nanaya
Use same styling between beatmap description and user 'me' page
7bdbf37
@nanaya
Update hype page padding
18f4f7c
@nanaya
Merge remote-tracking branch 'origin/master' into new-beatmap-page
c4aa869
@nanaya
Merge remote-tracking branch 'origin/master' into new-beatmap-page
04ce925
@nanaya
Merge remote-tracking branch 'origin/master' into new-beatmap-page
bf1bb07
@nanaya
Merge branch 'beatmap-guest-name' into new-beatmap-page
96d55d5
@nanaya
Use the new related_users
447b6f2
@nanaya
Tags not in beatmapset json
43eb03d
@notbakaneko notbakaneko marked this pull request as draft November 7, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaya nanaya nanaya requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area:beatmap-info waiting-on-design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new design of beatmapset info page
6 participants
@gagahpangeran @nanaya @peppy @mcendu @frenzibyte @arflyte