Use mobx for follow user button #11216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
requested changes
May 17, 2024
| super(props); | ||
| makeObservable(this); | ||
|
|
||
| this._following = this.props.following; |
There was a problem hiding this comment.
as this is the only place using this props, might as well remove the default value and make it optional?
looking again, none of the ones using it passes the value so just always init to true? Or put the actual state on page so it can be restored on navigation
| following: core.currentUserModel.following.has(this.props.follow.notifiable_id), | ||
| }); | ||
| } | ||
| this.xhr?.abort(); |
| }; | ||
| private get following() { | ||
| return this.props.follow.subtype === 'mapping' | ||
| ? core.currentUserModel.following.has(this.props.follow.notifiable_id) |
There was a problem hiding this comment.
the field name should be something like followUserMapping instead of following...
|
|
||
| private readonly eventId = `follow-toggle-${nextVal()}`; | ||
| private toggleXhr: null | JQueryXHR = null; | ||
| @observable _following: boolean; |
| } | ||
|
|
||
| componentDidMount() { | ||
| if (this.props.follow.subtype === 'mapping') { | ||
| $.subscribe(`user:followUserMapping:refresh.${this.eventId}`, this.refresh); |
There was a problem hiding this comment.
there doesn't seem to be anything using this event anymore so the publish can be removed
nanaya
requested changes
May 17, 2024
| @observer | ||
| export default class FollowToggle extends React.PureComponent<Props> { | ||
| @observable private _following = true; | ||
| private readonly jsonId = `json-follow-toggle-${this.props.follow.subtype}-${this.props.follow.notifiable_type}-${this.props.follow.notifiable_id}`; |
There was a problem hiding this comment.
this should be a getter? doesn't matter now but it'll probably break if the component is ever shuffled around and get passed a different set of props
nanaya
changed the title
nanaya
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the
being read outside a reactive contextwarning on user card tooltips