Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display changelog entries count on user profile link section #11005

Closed
wants to merge 3 commits into from

Conversation

tsunyoku
Copy link
Sponsor Member

Resolves #10962.

GitHub user linked

image

GitHub user not linked

image

@nanaya
Copy link
Collaborator

nanaya commented Feb 15, 2024

I really would rather not. It looks like it may motivate people in the wrong way.

@tsunyoku
Copy link
Sponsor Member Author

I understand where you're coming from, but I don't think it's going to motivate people in the wrong way any more than somebody may already be (changelogs display the user for each changelog entry, GitHub has contributors tab with similar statistics)

@notbakaneko
Copy link
Collaborator

I don't see how this is meaningful? Might as well count the number of lines I write
and I put
everything on a new line
since that increases
it
faster

@cl8n
Copy link
Member

cl8n commented Feb 16, 2024

I can understand the issue as well and I usually oppose similar things using nanaya's reasoning, but I don't view this one as much different from the neighboring forum post or comment counts. it's just an attempt to attribute somehting to the user, even though the value itself is measuring a very arbitrary thing. it would be cool if this could instead link to some page showing what the user contributed, like a filtered changelog or somethn, but I imagine that is not straightforward to implement like this currently is.

but if the number is really that big of a deal then I guess just link github alongside the other mediaKeys ..?

@peppy
Copy link
Sponsor Member

peppy commented Feb 16, 2024

i dunnnnnno

@tsunyoku
Copy link
Sponsor Member Author

okay, understandable. how about clayton's suggestion and we just display the user's github as another social with no stats?

@frenzibyte
Copy link
Member

That just feels weird. GitHub doesn't really have any place in osu!.

@tsunyoku
Copy link
Sponsor Member Author

I don't think this should really exist.

@tsunyoku tsunyoku closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show changelog contribution count & GitHub profile on user page
6 participants