Show rank changes on performance ranking #10597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need some help with caching this per request because currently it gets called 50 times on a ranking page. I don't know the best way to do it osu-web/app/Models/RankHistory.php Line 123 in 69bc11a |
|
is it normal to have "least recent" ranking to compare against when the others are 30 days? Isn't it usually just |
yeah I guess this could be misleading in some way. I've changed it so that only the history at exactly 30 days is checked, and everything has an icon of some form now. also further tooltip to explain the "not enough history" case |
nanaya
requested changes
May 24, 2024
nanaya
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7391