Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter for Less #10592

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Add linter for Less #10592

wants to merge 6 commits into from

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Sep 24, 2023

mostly so things can be fixed automatically and you don't have to care about formatting so much. the enabled rules that can't be fixed automatically seem like good suggestions and already had very few errors in this project

  • will conflict with Simplify Webpack config #10568 because postcss dependency
  • I haven't tested the formatting for GitHub action
  • some of the rules should probably be warnings instead of errors

@nanaya
Copy link
Collaborator

nanaya commented Sep 25, 2023

I don't think stylelint-stylistic is supposed to be used for new projects.

@cl8n
Copy link
Member Author

cl8n commented Sep 25, 2023

I looked into stylelint's recommended migration path for their stylistic rules (tl;dr try Prettier) -- it doesn't really align with the goal I had here of being non-intrusive. I wanted the result to be similar to osu-web's ESLint config in that you can still make some formatting decisions yourself where it makes sense, it just lints the tedious things that we agree should always be done a certain way

so I went with their next recommendation which is to depend on someone else maintaining similar rules, and this is the most popular option.

@nanaya
Copy link
Collaborator

nanaya commented Oct 30, 2023

prettier can be configured to only handle css files

I took a quick look of its output and it seems fine (apart of mod names need quoting)

as for customization, I think we would care more about customizing actual lint than formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants