-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group history page #10430
base: master
Are you sure you want to change the base?
Add group history page #10430
Conversation
This also includes all groups the user can normally view, for use in a group selector
lol
ebcc04d
to
80eb4e3
Compare
@bold-events: group-add, group-remove, group-rename; | ||
each(@bold-events, { | ||
&--@{value} { | ||
--message-weight: bold; | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combine with below?
> :nth-child(-n + 2) { | ||
grid-column: span 2; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set on the elements themselves?
text={trans('common.buttons.reset')} | ||
/> | ||
<BigButton | ||
disabled={newParamsSame || this.props.loading} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing the form while still loading should re-enable the button?
(and fwiw pressing enter still works)
if (cursorString == null) { | ||
this.events = response.events; | ||
} else { | ||
this.events.push(...response.events); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
navigating away and then back removes the loaded events
<InputContainer for={`${bn}-group`} labelKey='group_history.form.group'> | ||
<div className='form-select form-select--group-history'> | ||
<select | ||
className='form-select__input' | ||
id={`${bn}-group`} | ||
name='group' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for
, name
, and id
aren't needed?
part 4~ resolves #6216
full page screenshots
the search form is basically same as featured artists track search and the events list is basically same as user profile recent activity area. the icon BGs light up with the group's color, if it has one.
This page is now available at https://osu.ppy.sh/groups/history.