Add popup preview #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rockmanvnx6 how do you have your subsections properly nested? For example when minimizing the AWS Certified Developer section all of the sub-folders get hidden. Peters example sites doesn't do that. |
|
I answered my own question - I just checked out out your fork :P |
rockmanvnx6
force-pushed
the
preview-popup
branch
from
22807db
to
fea526c
Compare
|
Can this be done the same for the notes in the sidebar? |
|
@Yarden-zmr Should be able to without much changes. I'm not planning to add it in however since it sounds to me this might be dependent on one's preferences. Please feel free to modify the code for your usage. |
|
Hello ! thanks for the update and nice work ! Can't wait to get it pulled ! |
janeilagan
added a commit
to janeilagan/obsidian-zola
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi-layer preview popup as suggested from #42 suggested by @Yilunma1
The behavior is similar to obsidian publish (can view a preview within a preview)
Supports both light and dark theme. It only works on /docs/ link, used a hashmap to prevent continuously fetching.
Update: added preview based on block id
live demo: https://swe.auspham.dev/docs/aws-certified-developer-dva-c01/aws-security-and-encryption/aws-kms-limitations/
Please lemme know if it looks good or anything that needs to be changed