Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a non-root base path #34

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

trwbox
Copy link
Contributor

@trwbox trwbox commented Jun 22, 2022

This adds an optional BASE_PATH in the configuration file that could be used for something like example.github.io/obsidian-notebook/.

The format has BASE_PATH with no slashes BASE_PATH = "obsidian-notebook", and requires that SITE_URL is changed accordingly, and including a trailing backslash to be like SITE_URL = https://example.github.io/obsidian-zola/

@ppeetteerrs
Copy link
Owner

@trwbox Thanks for the pull request! It looks good. Can I know if you have a working demo of a github.io hosted site? It would be helpful in additional to my offline testing.

@trwbox
Copy link
Contributor Author

trwbox commented Jun 27, 2022 via email

@trwbox
Copy link
Contributor Author

trwbox commented Jun 29, 2022

I got it created here is a link to the site:
https://www.trwbox.com/obsidian-path-vault/.

A good example page is Antenna on PCB to see the graph, and that in content links work.

And here is a link to the github repo:
https://github.com/trwbox/obsidian-path-vault

@ppeetteerrs
Copy link
Owner

The pull request seems reasonable. I would incorporate it in the next release. However, I might not include the BASE_PATH option in netlify.example.toml as it might be a little confusing to the majority. I will add a section in the README.md to explain how to host on alternative platforms.

@trwbox
Copy link
Contributor Author

trwbox commented Jul 7, 2022

That makes perfect sense. I added it for consistency sake, but have no issues if it is a part of the readme. I know this might be considered promoting my own project in asking, but if you add that section would you mind linking my Github Pages publishing tool?

https://github.com/trwbox/obsidian-zola-build-action

@master4x
Copy link

master4x commented Mar 9, 2023

When will this Pull Request be merged?
I also ran into this issue a few moth ago with GitHub Pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants