Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rao elementary action by core action #920

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

pjeanmarie
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@pjeanmarie pjeanmarie requested a review from obrix March 11, 2024 13:59
@pjeanmarie pjeanmarie self-assigned this Mar 11, 2024
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch 2 times, most recently from 0ff2a6c to 518b0c3 Compare March 11, 2024 17:15
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch 2 times, most recently from 381dfda to 1b2ca89 Compare March 19, 2024 08:48
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch 4 times, most recently from e3881fe to 6ee0599 Compare April 2, 2024 13:27
@pet-mit pet-mit marked this pull request as draft April 4, 2024 14:15
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch 2 times, most recently from 1f76983 to 8ef8af4 Compare April 10, 2024 09:31
@pet-mit pet-mit removed the PR: WIP label Apr 11, 2024
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch 4 times, most recently from 53b9e7d to af0a91b Compare April 23, 2024 13:49
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch 9 times, most recently from 2787a91 to b03ec03 Compare May 7, 2024 08:42
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch from b03ec03 to 4b627de Compare May 13, 2024 16:30
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch 6 times, most recently from 8e0e299 to fdefc4a Compare May 17, 2024 15:20
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch 2 times, most recently from 53c3a8d to 5d25c0a Compare May 23, 2024 08:21
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch from 5d25c0a to e71e572 Compare May 31, 2024 17:35
@pjeanmarie pjeanmarie changed the title WIP: Replace rao elementary action by core action Replace rao elementary action by core action Jun 5, 2024
@pjeanmarie pjeanmarie added the PR : pending-for-dependency-release This PR can't be merged until one dependency is updated label Jun 5, 2024
@pjeanmarie
Copy link
Member Author

Do not merge: Need next core version (6.4.0), then pom need to be updated (6.4.0-SNAPSHOT -> 6.4.0) and changes on CI files need to be removed.

@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch from e71e572 to 307c918 Compare June 5, 2024 08:42
@pjeanmarie pjeanmarie added the breaking-change Changes could break users' code label Jun 7, 2024
Pauline Jean-Marie added 3 commits June 7, 2024 15:10
…ial action modification

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
- PR7 and PR17 had actions of type A05 done on generator (and not load), it should be type A04
- PR17 had action B24 done on switch (not transformer), it should be A07

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch from 307c918 to 7ea95f7 Compare June 7, 2024 15:47
Pauline Jean-Marie added 9 commits June 10, 2024 17:19
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
…n apply as a first step to replace rao action by core action

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
…on, so they are moved out of elementary action

Remove network elements from elementary action since core remedial action do not have network element(s)

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
…ompiles)

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
…ir tests (not cucumber)

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
…cucumber tests which verified the type of elementary actions

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
…bility test and exhaustive crac creation test

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
@pjeanmarie pjeanmarie force-pushed the replace_rao_elementary_action_by_core_action branch from 7ea95f7 to f7a1e93 Compare June 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes could break users' code PR : pending-for-dependency-release This PR can't be merged until one dependency is updated
Projects
None yet
2 participants