Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check physical parameters in RaoResult's isSecure #905

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Feb 28, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Fixes #898

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@pet-mit pet-mit added the bug Something isn't working label Mar 22, 2024
# Conflicts:
#	monitoring/angle-monitoring/src/main/java/com/powsybl/openrao/monitoring/anglemonitoring/RaoResultWithAngleMonitoring.java
#	monitoring/voltage-monitoring/src/main/java/com/powsybl/openrao/monitoring/voltagemonitoring/RaoResultWithVoltageMonitoring.java
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29 bqth29 requested a review from pet-mit March 22, 2024 14:30
@bqth29 bqth29 added the PR: waiting-for-review This PR is waiting to be reviewed label Mar 28, 2024
Copy link
Collaborator

@pet-mit pet-mit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall OK for me, but will break an actual behavior that is currently not tested.
I added some tests here: #966
We'll have to update this PR after the tests are merged

@pet-mit pet-mit added PR: waiting-for-correction This PR is waiting to be corrected by its author PR : pending-for-dependency-release This PR can't be merged until one dependency is updated PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) and removed PR: waiting-for-review This PR is waiting to be reviewed PR : pending-for-dependency-release This PR can't be merged until one dependency is updated labels Apr 11, 2024
@pet-mit
Copy link
Collaborator

pet-mit commented Apr 11, 2024

mustn't be merged before #966 (some corrections will then be needed here)

@pet-mit pet-mit removed the PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) label Apr 11, 2024
pet-mit and others added 3 commits April 12, 2024 09:33
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@pet-mit pet-mit added the PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) label Apr 22, 2024
@pet-mit
Copy link
Collaborator

pet-mit commented Apr 22, 2024

Mustn't be merge before #969 (test will need adaptation of the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) PR: waiting-for-correction This PR is waiting to be corrected by its author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Flow RaoResult, when calling isSecure, ensure that it is called on FLOW parameter
2 participants