-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNEC geographical filter for CSA Profiles import #861
Draft
bqth29
wants to merge
16
commits into
main
Choose a base branch
from
csa/geographical_filter
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pet-mit
requested changes
Jan 11, 2024
...l/open_rao/data/crac_creation/creator/csa_profile/crac_creator/cnec/AbstractCnecCreator.java
Outdated
Show resolved
Hide resolved
...l/open_rao/data/crac_creation/creator/csa_profile/crac_creator/cnec/AbstractCnecCreator.java
Outdated
Show resolved
Hide resolved
...bl/open_rao/data/crac_creation/creator/csa_profile/crac_creator/cnec/GeographicalFilter.java
Outdated
Show resolved
Hide resolved
...bl/open_rao/data/crac_creation/creator/csa_profile/crac_creator/cnec/GeographicalFilter.java
Outdated
Show resolved
Hide resolved
...bl/open_rao/data/crac_creation/creator/csa_profile/parameters/CsaCracCreationParameters.java
Outdated
Show resolved
Hide resolved
...pen_rao/data/crac_creation/creator/csa_profile/crac_creator/cnec/GeographicalFilterTest.java
Outdated
Show resolved
Hide resolved
...pen_rao/data/crac_creation/creator/csa_profile/crac_creator/cnec/GeographicalFilterTest.java
Outdated
Show resolved
Hide resolved
...en_rao/data/crac_creation/creator/csa_profile/crac_creator/cnec/VoltageCnecCreationTest.java
Outdated
Show resolved
Hide resolved
...pen_rao/data/crac_creation/creator/csa_profile/parameters/CsaCracCreationParametersTest.java
Outdated
Show resolved
Hide resolved
...rao/data/crac_creation/creator/csa_profile/parameters/JsonCsaCracCreationParametersTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
bqth29
force-pushed
the
csa/geographical_filter
branch
from
January 11, 2024 15:05
41adfa5
to
7f06274
Compare
# Conflicts: # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/CsaProfileCracCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/AbstractCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/AngleCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/CsaProfileCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/GeographicalFilter.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/VoltageCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/parameters/CsaCracCreationParameters.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/parameters/JsonCsaCracCreationParameters.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/CsaProfileCracCreatorTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/AngleCnecCreationTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecCreationTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/GeographicalFilterTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/VoltageCnecCreationTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/parameters/CsaCracCreationParametersTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/parameters/JsonCsaCracCreationParametersTest.java
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
jipea
reviewed
Jan 16, 2024
...owsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/GeographicalFilter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
# Conflicts: # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/CsaProfileCracCreationTestUtil.java
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
TSO_AE (mRID) - TSO_CO - instant - TATL duration
)CsaCracCreationParameters
extension was added. The only current parameter is used to activate/deactivate the geographical filter. By default, the filter is disabled. If no CSA extension is provided with theCracCreationParameters
, the filter is also considered to be disabled. Below is an example of JSON-serializedCsaCracCreationParameters
:Does this PR introduce a breaking change or deprecate an API?