remove intensitySensitivities variable from SystematicSensitivityResult #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
force-pushed
the
remove_intensitySensitivities_from_sensi_calculation
branch
from
af8bdd6
to
ddc599c
Compare
Signed-off-by: belthlemar <martin.belthle@rte-france.com>
MartinBelthle
force-pushed
the
remove_intensitySensitivities_from_sensi_calculation
branch
from
ddc599c
to
5d38bff
Compare
|
@phiedw any idea why Peter marked this PR as draft ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Code cleaning
What is the current behavior?
When running a sensitivity analysis, we fill the map
intensitySensitivitiesbut we never use it.What is the new behavior (if this is a feature change)?
I removed this map from the class
SystematicSensitivityResult. I also made 2 very little changes to optimize the code.Does this PR introduce a breaking change?
No