-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RELATIVE_TO_PREVIOUS_TIMESTEP Range Type #1013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
phiedw
previously approved these changes
May 16, 2024
OpenSuze
reviewed
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR !
...-io/crac-io-json/src/test/java/com/powsybl/openrao/data/craciojson/CracImportExportTest.java
Show resolved
Hide resolved
...ac-io-json/src/test/java/com/powsybl/openrao/data/craciojson/JsonRetrocompatibilityTest.java
Outdated
Show resolved
Hide resolved
data/crac/crac-impl/src/main/java/com/powsybl/openrao/data/cracimpl/PstRangeActionImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
OpenSuze
approved these changes
May 24, 2024
OpenSuze
added
PR: ready-to-be-merged
This PR is waiting to be merged
and removed
PR: waiting-for-review
This PR is waiting to be reviewed
labels
May 24, 2024
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
* Add Relative_to_previous_timestamp Range Type Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com> Signed-off-by: belthlemar <martin.belthle@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
There is currently 3 RangeTypes for PST ranges: Absolute, Relative to previous instant and Relative to initial network
What is the new behavior (if this is a feature change)?
Added a new RangeType : relative to previous timestep. This RangeType allows to limit the variation of the tap of the PST compared to its value durint the previous time-step
Does this PR introduce a breaking change or deprecate an API?