Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RELATIVE_TO_PREVIOUS_TIMESTEP Range Type #1013

Merged
merged 9 commits into from
May 24, 2024

Conversation

wangjer
Copy link
Collaborator

@wangjer wangjer commented May 16, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Feature

What is the current behavior?
There is currently 3 RangeTypes for PST ranges: Absolute, Relative to previous instant and Relative to initial network

What is the new behavior (if this is a feature change)?
Added a new RangeType : relative to previous timestep. This RangeType allows to limit the variation of the tap of the PST compared to its value durint the previous time-step

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
@wangjer wangjer requested a review from phiedw May 16, 2024 13:58
phiedw
phiedw previously approved these changes May 16, 2024
@OpenSuze OpenSuze added PR: waiting-for-review This PR is waiting to be reviewed labels May 24, 2024
@OpenSuze OpenSuze requested review from OpenSuze May 24, 2024 09:34
Copy link
Collaborator

@OpenSuze OpenSuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
@OpenSuze OpenSuze added PR: ready-to-be-merged This PR is waiting to be merged and removed PR: waiting-for-review This PR is waiting to be reviewed labels May 24, 2024
@OpenSuze OpenSuze marked this pull request as ready for review May 24, 2024 11:57
@phiedw phiedw merged commit 8210fdb into main May 24, 2024
8 of 9 checks passed
@phiedw phiedw deleted the feature/rangeType_relToPreviousTs branch May 24, 2024 12:22
MartinBelthle pushed a commit that referenced this pull request May 28, 2024
* Add Relative_to_previous_timestamp Range Type

Signed-off-by: JeremyWangRTE <jeremy.wang@rte-france.com>
Signed-off-by: belthlemar <martin.belthle@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready-to-be-merged This PR is waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants