Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CgmesDLImportPostProcessor fix #617

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CgmesDLImportPostProcessor fix #617

wants to merge 4 commits into from

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented May 3, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
File containing CGMES DL profile needs to have the exact same prefix as EQ profile file to be imported

What is the new behavior (if this is a feature change)?
CGMES DL data does not need to be in a specific file with a specific profile name.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Copy link
Collaborator

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an easy way to refactor the CgmesDLModelTest > setUp() and/or CgmesDLModelTest > setQuery(...) functions to be able to test the CgmesDLImporter > import[...]DLData()empty cases? Or maybe use parametrized tests?

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76.9% Coverage on New Code (required ≥ 90%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants