Do not compute forces, velocity and position for fixed points #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
So-Fras
reviewed
May 13, 2024
diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/ForceLayout.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
So-Fras
reviewed
May 22, 2024
| @@ -302,15 +314,10 @@ private void updateVelocity() { | |||
| } | |||
|
|
|||
| private void updatePosition() { | |||
| // TODO do not compute forces or update velocities for fixed nodes | |||
| // We have computed forces and velocities for all nodes, even for the fixed ones | |||
There was a problem hiding this comment.
// We have computed forces and velocities for all nodes, even for the fixed ones
// We can optimize calculations by ignoring fixed nodes in those calculations
Are those comments up-to-date? Is velocity still computed for fixed points and is there still a possibility for optimization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
"Bug" fix
What is the current behavior?
Forces and velocity are computed for fixed points
What is the new behavior (if this is a feature change)?
Forces and velocity are not computed for fixed points
Does this PR introduce a breaking change or deprecate an API?