Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor editors code #1507

Open
wants to merge 46 commits into
base: develop
Choose a base branch
from
Open

[WIP] Refactor editors code #1507

wants to merge 46 commits into from

Conversation

ZyX-I
Copy link
Contributor

@ZyX-I ZyX-I commented Dec 5, 2015 •
edited

There are three long-term targets here: Vim without +python, neovim (ref #1287) and emacs. Main idea is reducing the necessity to communicate with the editor to nearly one stage. This PR is doing refactoring of the code, not adding new applications to support.

TODO:

  • Create new way to describe powerline requirements.
  • Update all segments which can be updated to use this new way.
  • (partial: missing type conversions) Update all segment listers to use this new way.
  • Remove dependency on the vim module: import it once at startup and pass it around.
  • Update development documentation regarding vim segments.
  • Create documentation describing how to create new Vim segments.
  • Create documentation describing how to add new editors support.
  • Move non-vim-specific editor segments to powerline.segments.editors module.
  • Make all remaining powerline.segments.vim* modules powerline.segments.editors.
  • Move all vim listers to powerline.listers.editors since they are not vim-specific. Requires doing something with buffer, window, tabpage, bufnr, winnr, tabnr segment_info keys.
  • Make documentation for listers point to new location.
  • Make documentation for segments point to new location.
  • Make cvs_col_current segment non-editor-specific. Requires abstracting buffer lines access.

@ZyX-I ZyX-I added this to the 3.0 milestone Dec 5, 2015
@ZyX-I ZyX-I force-pushed the editors-refactor branch 2 times, most recently from ff1cdb7 to 1d01df7 Compare April 29, 2017 21:50
@ZyX-I ZyX-I mentioned this pull request Apr 29, 2017
Merged
@ZyX-I ZyX-I mentioned this pull request Jun 4, 2017
Open
ZyX-I added 16 commits July 13, 2017 23:03
@ZyX-I
Remove direct access to Vim-specific objects from segments
a3a90f5 
Reasoning:

1. Support other editors in the future without rewriting all bindings.
2. Support Vim without +python.
@ZyX-I
Modify vim unit tests so that they do not fail
2b18b2a
@ZyX-I
When there is no visual range output None in visual_range segment
e9c8bb5
@ZyX-I
Make segment lister segments partially work
8d80f85
@ZyX-I
Import vim module in one place only
68bd5f6 
Also removes `except ImportError: vim = object()` hack.

Removed code from powerline.bindings.vim that is no longer used.
@ZyX-I
Fix listed_indicator
2095c17 
EditorParameter('buffer') is buffer number only when using VimVimEditor.
@ZyX-I
Fix tablister
6c2bcbb 
- Fix typo: segment_info key is named input, not inputs
- Fix typo: parameter name is tabpage, not tab
@ZyX-I
Some fixes to fallback code
a7fe5ac 
Still not enough to run with is_old_vim = True
@ZyX-I
Use updated from powerline.lib.dict in place of reimplementing it
ae47d3a
@ZyX-I
Make old Vims support somewhat work
5f673a4 
It does not raise exceptions now, but still does not work correctly.
@ZyX-I
Add logical or, and and xor
644e5af
@ZyX-I
Convert arguments of binary and ternary operators to editor objects
b24bbb3
@ZyX-I
Use explicit None in return statement
0a28bad
@ZyX-I
Fix code used for new Vim’s, add g:powerline_old_vim variable
6701fdc
@ZyX-I
Refactor iterparam_updated and dependent code
9f22a84
@ZyX-I
Some fixes to tabline and listers, with refactoring
d5337f8 
Fixes:
- Conversion function did not recognize used keyword argument.
- Number of tab pages did not have a type.
- Updating tabpage or window parameters did not trigger updating buffer 
  parameter (also updating tabpage should have updated window), which resulted 
  in incorrect buffer names shown in the tabline when there are many tabs.

Refactoring:
- EditorObj objects used by listers are now EditorIterable subclasses.
- powerline.editors.vim.VimTabAmount is now powerline.editors.EditorTabAmount.
- Constant dictionaries used by segments_to_reqs_iter were moved to module 
  constants.
ZyX-I added 14 commits July 13, 2017 23:03
@ZyX-I
Add some fixes so that it runs fine as “old” vim on my setup
8c8f88b
@ZyX-I
Fix some problems
4085511 
This variant also supports Neovim, ref powerline#1287.
@ZyX-I
Refactor some theme conversion methods
605ed2b
@ZyX-I
Use NotImplementedError in place of pass for Editor abstract methods
ac88425
@ZyX-I
Add some documentation for matchers
8ba0a6c
@ZyX-I
Update documentation
2ea7eb9
@ZyX-I
Save type information when using listers
846a150
@ZyX-I
Save source code of various compiled functions
6e634a3
@ZyX-I
Fix some issues with tabline
eedfc17 
Still known issues:

1. When opening new tab in old vim mode new window in new tab appears as 
   unfocused.
2. When opening new tab in new vim mode it raises AttributeError.

Fixed issues:

1. Tabline does not work at all.
2. Opening new tab spawns AttributeError when determining width.
3. TypeError when trying to use string tab number as integer.
4. Generated code looks like crap (VimVimEditor, conv_code).
5. Conversion code generated for listers does not actually work due to numerous 
   issues.
6. In some places tabline theme number is off-by-one.
7. Listing buffers lists only buffers that are shown in the current tab.
@ZyX-I
Defer using vim.windows until needed
f83b459
@ZyX-I
More lazy objects, make “new” bindings use win_getid() for window id
88fb524
@ZyX-I
Some statusline fixes
a308054 
Statusline after `tab sp` with new bindings is now fine. Still bad with old 
bindings.

Also found an issue: message from startup screen disappears.
@ZyX-I
Fix new tab issue and also do not call Vim for buffer number
33bedf9 
Known issue: with old vim if one tab contains modified buffer all tabs are shown 
as modified.
@ZyX-I
Do not use get_vim_encoding, there already is a value obtained as pre…
427b2e7 
…reqs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c:e:vim t:enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ZyX-I