Fix #108: Update Flask dependency #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
dgzlopes
force-pushed
the
issue-108-update-dependency
branch
from
410de43
to
cd163a4
Compare
dgzlopes
changed the title
|
Awesome, thanks for taking a stab at this ! Let's wait for them to resolve that issue, and hopefully we'll be warning free again ! |
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
dgzlopes
force-pushed
the
issue-108-update-dependency
branch
from
8a10392
to
70a21c2
Compare
|
Update on this one! Looks like a fix to the requests urlib version issue got merged today [0]. So using the new version (requests 2.22.0) makes us RequestsDependencyWarning free (passing tests on my fork!). On the other hand, looks like requests is dropping support for Python 3.4 on this new version! just writing this in the case is useful in the future. |
|
Awesome ! I'll take it for a spin as soon as I get any free bandwidth ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked the dependency to Flask [0] and it has been fixed [1] on flask >1.0 (It was related with the JSONIFY_PRETTYPRINT_REGULAR default) so I updated the dependency and seems to solve #108 .
On the other side, fixing this generates the following warning:
On Python 2.7,3.4,3.5,3.7:
.tox/py27/lib/python2.7/site-packages/requests/__init__.py:91 /home/travis/build/dgzlopes/powerfulseal/.tox/py27/lib/python2.7/site-packages/requests/__init__.py:91: RequestsDependencyWarning: urllib3 (1.25) or chardet (3.0.4) doesn't match a supported version! RequestsDependencyWarning)Seems to come from Requests and as reflected on this issue [2] looks like they are working on solving it!
[0] pallets/flask#2549
[1] http://flask.pocoo.org/docs/1.0/changelog/
[2] https://github.com/kennethreitz/requests/issues/5067