fix: sorting by selected column in template records

poweradmin · Dec 2, 2023 · 992e946 · 992e946
1 parent 911ac98
commit 992e946
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/lib/ZoneTemplate.php b/lib/ZoneTemplate.php
@@ -247,6 +247,9 @@ public static function get_zone_templ_records($db, int $id, int $rowstart = 0, i
     {
         $db->setLimit($rowamount, $rowstart);
 
+        $allowedSortColumns = ['name', 'type', 'content', 'priority', 'ttl'];
+        $sortby = in_array($sortby, $allowedSortColumns) ? $sortby : 'name';
+
         $stmt = $db->prepare("SELECT id FROM zone_templ_records WHERE zone_templ_id = :id ORDER BY " . $sortby);
         $stmt->execute([':id' => $id]);
 

diff --git a/templates/edit_zone_templ.html b/templates/edit_zone_templ.html
@@ -24,17 +24,12 @@ <h5 class="mb-3">{% trans %}Edit zone template{% endtrans %} "{{templ_details['n
 <form method="post" action="">
     <table class="table table-striped table-hover table-sm">
         <tr>
-            <th><a href="edit_zone_templ.php?id=" {{zone_templ_id}}&amp;record_sort_by=name">{% trans %}Name{% endtrans
-                %}</a></th>
-            <th><a href="edit_zone_templ.php?id=" {{zone_templ_id}}&amp;record_sort_by=type">{% trans %}Type{% endtrans
-                %}</a></th>
-            <th><a href="edit_zone_templ.php?id=" {{zone_templ_id}}&amp;record_sort_by=content">{% trans %}Content{%
-                endtrans %}</a></th>
-            <th><a href="edit_zone_templ.php?id=" {{zone_templ_id}}&amp;record_sort_by=prio">{% trans %}Priority{%
-                endtrans %}</a>
+            <th><a href="edit_zone_templ.php?id={{zone_templ_id}}&amp;record_sort_by=name">{% trans %}Name{% endtrans %}</a></th>
+            <th><a href="edit_zone_templ.php?id={{zone_templ_id}}&amp;record_sort_by=type">{% trans %}Type{% endtrans %}</a></th>
+            <th><a href="edit_zone_templ.php?id={{zone_templ_id}}&amp;record_sort_by=content">{% trans %}Content{% endtrans %}</a></th>
+            <th><a href="edit_zone_templ.php?id={{zone_templ_id}}&amp;record_sort_by=prio">{% trans %}Priority{% endtrans %}</a>
             </th>
-            <th><a href="edit_zone_templ.php?id=" {{zone_templ_id}}&amp;record_sort_by=ttl">{% trans %}TTL{% endtrans
-                %}</a></th>
+            <th><a href="edit_zone_templ.php?id={{zone_templ_id}}&amp;record_sort_by=ttl">{% trans %}TTL{% endtrans %}</a></th>
             <th>&nbsp;</th>
         </tr>
         {% for record in records %}