New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ci workflow node environments #8664
update ci workflow node environments #8664
Conversation
@SourceR85 Would you mind resolving the conflict and running the build again with the new test suites? |
ef9ea9e
to
12974e0
Compare
…rceR85/pouchdb into update-node-test-environment
@garethbowen Hi, can you re-execute the ci-workflow? (best case: running only the failing tests) There was a network problem in two test-runner environments:
Everything else was running fine. |
@SourceR85 I've re-run and everything passed. GitHub isn't happy because you've changed the builds so some "required" builds never ran. This is not a blocker. However I'm a little concerned about dropping support for Node 14, not because we shouldn't do it, but it's a breaking change so we should probably do a major release. What do you think? |
I don't think we should be shy about dropping support for EOL'd node versions. Even node 16 is EOL at this point. |
I agree, but needs communication, probably a major version bump is correct. With everything else that's merged, or soon to be merged (I hope), but not yet released, we should probably be talking about a major release anyway. |
Since node 16 CI-Actions will be automatically upgraded to node 20 in march, I think we already have a release date. |
How's your suggestion, should I drop node 16 too? Add 21? |
I don't mind about 16, but I don't think it's necessary. I don't think odd-numbered releases should be included. I would prefer to see unrelated changes to whitespace and But overall, I'm happy to see this merged once the build is passing. |
Found (and fixed) out-of-bound exceptions: #8861 |
Okay, everything's ✅ |
LGTM. I'm happy to change the branch protection rules but this has to be coordinated because it'll block any other PRs until this is merged. @janl Can I get your thumbs up on this PR before we officially drop support for old Node versions? |
Switch from node 14 & 16 to 18 and 20
Aligns with currently supported node versions
https://nodejs.dev/en/about/releases/
I've added node 20, so we get compatibility feedback from within ci pipelines.
Benefits: