(#8494) - Refreshes seq before indexeddb bulkDocs #8495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broerse
approved these changes
Mar 20, 2023
|
We need this fix to get PouchDB with this new adapter working in multiple browser tabs. |
alxndrsn
reviewed
Apr 5, 2023
| @@ -314,6 +314,17 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback) | |||
| }; | |||
| } | |||
|
|
|||
| function refreshMetadataSeq() { | |||
| return new Promise(function (resolve) { | |||
| txn.objectStore(DOC_STORE).index('seq').openCursor(null, 'prev').onsuccess = function (evt) { | |||
There was a problem hiding this comment.
Would this have the same effect as:
metaStore.get(META_STORE).onsuccess = function (e) {
metadata.seq = e.target.result.seq;
...
}?
There was a problem hiding this comment.
I will have to spend some time analyzing it. It's been too long for me to remember the technical details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not unit test yet. I would need some guidance on where to create those, and perhaps how to create a multi-page scenario as well.