Adjust revs_limit in existing test to reproduce RangeError #8396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all stack size exceeded
|
Hmmm, I guess this only fails on Windows Chrome. I'm not sure if reporting this as a bug on Chrome is worth it, but here is the bug tracker: https://bugs.chromium.org/p/chromium/issues/detail?id=1263612 |
|
The Chromium issue got tagged Wontfix, so we might have to decide if we want to do something about this on our side. I'll make a separate issue for that. |
Linux does not have a problem with 1000 revisions, let's see if 4900 will work
|
Test if higher revision count will trigger this. |
|
The pouchdb-server failure is unexpected, but the change to use 4900 as revs_limit reproduces the RangeError now on both Firefox and Chrome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fail for indexeddb on the following test:
test.bulk_docs.js-local2839 implement revs_limit