Handle non-buffer binary data in node #8198
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between browser and node generally works well. However, there are some instances in which the boundaries are not that clear. For example:
I bumped into this issue when testing attachments in my application. I believe these changes fix the issue.
Apologies for not adding any tests. This is my first contribution and for what I can see, node tests are run with mocha and browser tests with a headless browser.
If tests are required, I can add them but I'd need to know which would be the best way of replicating those two use cases above in current tests setup. Any help in this regards would be much appreciated