Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for modifying instance methods from PouchDB.prototype #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for modifying instance methods from PouchDB.prototype #3

wants to merge 1 commit into from

Conversation

geodic
Copy link

@geodic geodic commented Sep 19, 2022

The replacementMethod binds base as the thisArg to the wrapper function and the original function. This makes it break when you want to modify instance properties from PouchDB.prototype. Thus, instead of using base if you use this you can modify instance properties from PouchDB.prototype too.

@geodic geodic changed the title Add support for modifying instance methods from PouchDB.prototypeMaster Add support for modifying instance methods from PouchDB.prototype Sep 19, 2022
@geodic
Copy link
Author

geodic commented Sep 19, 2022

Oops, title typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@geodic