Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching non-saved hasMany relationships #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adezegher
Copy link

When creating a hasMany - hasMany relationship it is possible to only save one side of the relation, to reduce the risk of merge conflict.

However, the current implementation, only loads the unsaved side for a hasMany - belongsTo relationship, but not for a hasMany - hasMany relationship.

This change, allows to load the unsaved side in a hasMany - hasMany relationship, in a similar way hasMany - belongsTo does

@broerse
Copy link
Collaborator

broerse commented May 5, 2020

Not sure this is the way to go. It will not work without setting save: true on one side in your Ember model. If you later want to do this the other way around you are in for a challenge. We should solve this in a more constant way. What if App1 from team 1 has the save: true defined on the other side then App2 from team 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants