Added options to disable live sync and support for periodic polling for changes #140

simonexmachina · 2016-09-14T13:03:34Z

No description provided.

@mattmarcum

Unit test courtesy of Matt Marcum @mattmarcum

* upstream/master: (32 commits) fixing readme reference to config key, concerning adapter blueprint. 3.2.1 Fix(Addon): Call super in init 3.2.0 Add relationship documentation Update README.md update readme update readme 3.1.1 (pouchdb-community#16) - Add override so serialiser saves hasMany Pouch adapter now calls a hook method when encountering a change for a record that is not yet loaded. update readme 3.1.0 Fix version check for Ember Data 3.2.x Update changelog for pouchdb-community#103 Tests for existing change watcher behavior Factor out integration test setup into module helper Move blueprint files into explicit directories Changelog for pouchdb-community#101 and pouchdb-community#102. created blueprint for pouch-adapter ...

@fsmanuel

As suggested by @fsmanuel in pouchdb-community#128 and pouchdb-community#131.

…reserved

[skip ci]

- Use Ember.get so that POJOs can be used instead of Ember.Object instances

…al-couch correctly

…lyfill for PhantomJS when running tests. - Add Ember.run() to taco-salad adapter to avoid exceptions when running tests

…ata/ember-cli

…r changes

simonexmachina · 2016-09-26T07:56:50Z

@broerse I'd like to get this PR merged, can you please review?

* upstream/master: (31 commits) Fix Typo 4.0.1 Fix Blueprint 4.0.0 Update README Updated README and changelog changed selector to filter implement glue code for query and queryRecord Check ember-data version and add install instructions for old ember-data/ember-cli Remove ember-data-1.13 from ember-try scenarios. Add Object.assign polyfill for PhantomJS when running tests. Tests passing in PhantomJS Added integration test Ensure that length is available when the attachment is first saved Change serializer so that attachments are passed to and from relational-couch correctly Update unit test Provide two transforms: `attachment` and `attachments` Return [] from serialize so that files can be added. Documentation for `defaultValue` of `attachment` Is fix a typo Deserialize "no attachments" into an empty array ...

broerse · 2016-09-29T05:11:31Z

@aexmachina I understand the need to specify the Change Notifacation type. But I don't think it should be a enable/disable flag. CouchDB has now 3 options, It could be more in the future. I also think this should be handled by pouchdb and from ember-pouch we just pass the option to pouchdb. So I am not sure we should merge this in this form.

simonexmachina · 2016-09-30T03:52:45Z

I probably should have been clearer about the intent of this PR. The goal is to allow an adapter to use a PouchDB instance that has an HTTP transport without using long polling. Currently, if you provide a PouchDB instance with an HTTP transport (i.e. directly to the remote - without a local) then the adapter's call to db.changes() will use long polling, which is a problem for us because we end up running out of sockets when multiple tabs are opened.

This PR provides two features to solve this:

liveSync: false disables the long polling
syncInterval: 10000 polls for changes every 10 seconds

broerse · 2016-09-30T04:49:20Z

@nolanlawson I think it is better to add something like a:

feed=normal
feed=longpoll
feed=continuous
feed=eventsource

option to pouchdb and we set this option in ember-pouch. Perhaps only support normal , longpoll , eventsource for now. What do you think?

simonexmachina · 2016-10-03T01:54:21Z

@broerse I agree that is a better solution, if @nolanlawson is open to adding support to PouchDB then I can look at doing a PR. Could take me a while to get to it though!

I'm thinking that adding a feed option to the #changes method would be the right way to expose this. Probably deprecating the live: true option and directing people to use feed: 'longpoll' instead.

broerse · 2016-10-03T12:01:07Z

feed: and live: are not the same. Live replication (or "continuous" replication) is a separate mode where changes are propagated between the two databases as the changes occur. In other words, normal replication happens once, whereas live replication happens in real time. So this does not need to be deprecated if we introduce feed:

simonexmachina · 2016-10-04T01:37:59Z

@broerse live: true would be equivalent to feed: 'longpoll'. Remember that in order to move this functionality to PouchDB it does need to be continuous i.e. repeatedly polling for changes or maintaining a long polling, continuous or SSE connection.

broerse · 2016-10-04T05:11:07Z

@aexmachina with live: true, feed: 'longpoll' is "continuous" replication. With live: false , feed: 'longpoll' replication happens once. Also with live: true, feed: 'normal' is "continuous" replication. With live: false , feed: 'normal' replication happens once. So we don't agree on that this is equivalent.

simonexmachina · 2016-10-05T05:53:03Z

Thanks for clarifying that @broerse, now I understand better. The feed option doesn't seem to be documented anywhere. It seems to me that the options interface could be better because live: false doesn't really make sense with any feed type other than normal. Hence my suggestion that live be replaced with feed. Anyway, I'm happy to take whatever guidance you or @nolanlawson want to offer.

On that note, @nolanlawson doesn't seem to be replying. Is there someone else I should be speaking to about this?

broerse · 2016-10-05T09:12:24Z

@aexmachina Perhaps you should open an issue on pouchdb asking for feed: 'longpoll' and feed: 'normal' support.

Stepan Stolyarov and others added 5 commits December 14, 2015 18:26

Attachment transform

c842ce8

Unit test courtesy of Matt Marcum @mattmarcum

Describe usage of Attachment transform

f11ba27

Test stubbed attachments

b6f074d

Clarify the use of base-64 encoded String attachments

3e5f36f

simonexmachina changed the title ~~Added option to disable live sync and support for periodic polling for changes~~ Added options to disable live sync and support for periodic polling for changes Sep 14, 2016

broerse and others added 24 commits September 23, 2016 10:01

Update Bower dependencies (pouchdb-community#137)

c397928

Correct import of Ember Data model blueprint

38f25cf

As suggested by @fsmanuel in pouchdb-community#128 and pouchdb-community#131.

3.2.2

c5355e6

Describe usage of Attachment transform

3c33665

Keep the length and digest properties of a stub attachment

95290bb

Test that digest and length properties of a stub attachment are p…

94f995e

…reserved

Add missing property on a test object

f746fd8

Deserialize "no attachments" into an empty array

3c9a072

Is fix a typo

97ede1b

[skip ci]

Documentation for defaultValue of attachment

6df6ee6

Return [] from serialize so that files can be added.

3c6162b

- Use Ember.get so that POJOs can be used instead of Ember.Object instances

Provide two transforms: attachment and attachments

02ea2a0

Update unit test

b0fea2b

Change serializer so that attachments are passed to and from relation…

412311b

…al-couch correctly

Ensure that length is available when the attachment is first saved

1de66b4

Added integration test

e57abbc

Tests passing in PhantomJS

1445d0e

Remove ember-data-1.13 from ember-try scenarios. Add Object.assign po…

c4e1550

…lyfill for PhantomJS when running tests. - Add Ember.run() to taco-salad adapter to avoid exceptions when running tests

Check ember-data version and add install instructions for old ember-d…

44cd398

…ata/ember-cli

implement glue code for query and queryRecord

400baaf

changed selector to filter

2707d01

Updated README and changelog

ea6c8bf

Update README

99ac186

4.0.0

a55a4bc

broerse and others added 7 commits September 23, 2016 11:38

Fix Blueprint

81b3f82

4.0.1

088b9f1

Added option to disable live sync and support for periodic polling fo…

2f0c8a3

…r changes

Improve README

9dc00e7

Allow sync() to be used in conjunction with liveSync

741bd75

Improve README

60f4e92

Fix Typo

b986642

simonexmachina force-pushed the sync-changes branch from 0518485 to b986642 Compare September 23, 2016 01:39

broerse mentioned this pull request Dec 21, 2016

feed: 'longpoll' and feed: 'normal' support pouchdb/pouchdb#6046

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added options to disable live sync and support for periodic polling for changes #140

Added options to disable live sync and support for periodic polling for changes #140

simonexmachina commented Sep 14, 2016

simonexmachina commented Sep 26, 2016

broerse commented Sep 29, 2016

simonexmachina commented Sep 30, 2016

broerse commented Sep 30, 2016

simonexmachina commented Oct 3, 2016

broerse commented Oct 3, 2016

simonexmachina commented Oct 4, 2016

broerse commented Oct 4, 2016

simonexmachina commented Oct 5, 2016

broerse commented Oct 5, 2016

Added options to disable live sync and support for periodic polling for changes #140

Are you sure you want to change the base?

Added options to disable live sync and support for periodic polling for changes #140

Conversation

simonexmachina commented Sep 14, 2016

simonexmachina commented Sep 26, 2016

broerse commented Sep 29, 2016

simonexmachina commented Sep 30, 2016

broerse commented Sep 30, 2016

simonexmachina commented Oct 3, 2016

broerse commented Oct 3, 2016

simonexmachina commented Oct 4, 2016

broerse commented Oct 4, 2016

simonexmachina commented Oct 5, 2016

broerse commented Oct 5, 2016