Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install PostGIS in the default db #11

Merged
merged 13 commits into from
Sep 11, 2015
Merged

Install PostGIS in the default db #11

merged 13 commits into from
Sep 11, 2015

Conversation

md5
Copy link
Contributor

@md5 md5 commented Aug 26, 2015

Fixes #4

@md5 md5 changed the title Install postgis in default db Install PostGIS in the default db Aug 26, 2015
This was referenced Aug 26, 2015
Closed
Closed
@md5
Copy link
Contributor Author

md5 commented Aug 26, 2015

Now that I look at this again and read over the comments in #2, I'm thinking that sourcing the scripts in contrib is not the right way to go, at least not for Postgres 9.1+...

I'm thinking that for everything except for 9.0, I just need to run CREATE EXTENSION postgis, CREATE EXTENSION postgis_topology, and CREATE EXTENSION postgis_tiger_geocoder, like I suggest in the README.md (well, at least the first two).

I'd appreciate getting some more feedback if anyone's following along at home, especially since this image appears to have gotten rather popular with 18k+ pulls from Docker Hub.

@md5
Copy link
Contributor Author

md5 commented Aug 26, 2015

I'll also add that docker-library/postgres#84 needs to be merged before POSTGRES_USER and POSTGRES_DB can be guaranteed to be set in our postgis.sh script.

@md5
Copy link
Contributor Author

md5 commented Aug 27, 2015

This PR has been updated to use CREATE EXTENSION on Postgres 9.1+ and the old method of sourcing files from contrib on Postgres 9.0.

@md5 md5 self-assigned this Aug 27, 2015
@md5 md5 force-pushed the install-postgis-in-default-db branch from 3fb866a to 829f26b Compare August 28, 2015 04:43
@md5
Copy link
Contributor Author

md5 commented Aug 28, 2015

The README.md has been updated.

@md5 md5 removed the needs docs label Aug 28, 2015
@md5 md5 force-pushed the install-postgis-in-default-db branch 4 times, most recently from d1263fb to 3fd4839 Compare September 1, 2015 05:24
@md5 md5 force-pushed the install-postgis-in-default-db branch from 56e337f to 4a20c3c Compare September 5, 2015 04:14
@md5
Copy link
Contributor Author

md5 commented Sep 11, 2015

I believe this is working as intended, so I'm going to merge it since there doesn't seem to be any more feedback coming in. Hopefully I haven't overlooked anything...

md5 added a commit that referenced this pull request Sep 11, 2015
@md5
Merge pull request #11 from appropriate/install-postgis-in-default-db
db11f82 
Install PostGIS in the default db
@md5 md5 merged commit db11f82 into master Sep 11, 2015
@md5 md5 deleted the install-postgis-in-default-db branch September 11, 2015 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@md5 md5

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@md5