an empty check would catch null ... while != "" will also match null …

…it feels wrong
postfixadmin · Jan 5, 2024 · 6e6e430 · 6e6e430
1 parent 0632d39
commit 6e6e430
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/model/TotpPf.php b/model/TotpPf.php
@@ -81,7 +81,8 @@ public function usesTOTP(string $username): bool
         ];
 
         $result = db_query_one($sql, $values);
-        if (is_array($result) && isset($result['totp_secret']) && $result['totp_secret'] != '') {
+
+        if (is_array($result) && isset($result['totp_secret']) && !empty($result['totp_secret'])) {
             return true;
         }
         return false;