see #523 - improve randomness when creating the PFA_token field; repo…

…rted by @michaellrowley via huntr.dev.
postfixadmin · Aug 4, 2021 · 25ac89f · 25ac89f
1 parent 99a549c
commit 25ac89f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/functions.inc.php b/functions.inc.php
@@ -108,7 +108,8 @@ function init_session($username, $is_admin = false)
     $_SESSION['sessid']['roles'] = array();
     $_SESSION['sessid']['roles'][] = $is_admin ? 'admin' : 'user';
     $_SESSION['sessid']['username'] = $username;
-    $_SESSION['PFA_token'] = md5(uniqid("", true));
+
+    $_SESSION['PFA_token'] = md5(random_bytes(8) . uniqid('pfa', true));
 
     return $status;
 }

diff --git a/public/users/login.php b/public/users/login.php
@@ -70,8 +70,7 @@
 if ($error) {
     flash_error($error);
 }
-
-$_SESSION['PFA_token'] = md5(uniqid('pfa'  . rand(), true));
+$_SESSION['PFA_token'] = md5(random_bytes(8) . uniqid('pfa', true));
 
 $smarty->assign('language_selector', language_selector(), false);
 $smarty->assign('smarty_template', 'login');