Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override contact_us_url value from contact-us gem #660

Open
wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

Override contact_us_url value from contact-us gem #660

wants to merge 2 commits into from
+6 −0

Conversation

aaronskiba
Copy link
Collaborator

Fixes #632

Changes proposed in this PR:

  • Our app uses the contact_us gem, which handles the values of contact_us_path and contact_us_url. However, DMP Assistant requires a custom a custom "contact-us" value. We currently have a solution for overriding contact_us_path. This PR modifies the codebase to apply that solution to contact_us_url as well.
  • Note that because our "contact-us" url is separate from our domain, I think it's ok to assign the url to both contact_us_path and contact_us_url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aaronskiba