Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/ci: store ui bundles in lfs #5107

Closed
wants to merge 2 commits into from
Closed

core/ci: store ui bundles in lfs #5107

wants to merge 2 commits into from

Conversation

calebdoxsey
Copy link
Contributor

Summary

Store index.js and index.css using LFS.

Related issues

For https://github.com/pomerium/internal/issues/1788

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the ci CI/CD and release automation label May 8, 2024
@calebdoxsey calebdoxsey requested review from a team as code owners May 8, 2024 17:34
@coveralls
Copy link

Coverage Status

coverage: 56.466% (+0.01%) from 56.453%
when pulling 3a1fb34 on cdoxsey/lfs
into d225288 on main.

@wasaga
Copy link
Contributor

wasaga commented May 8, 2024

do we need rebuild index.css/js ?

➜  pomerium-3 git:(cdoxsey/lfs) make build 
==> yarn
cd ui ; yarn install --network-timeout 120000
yarn install v1.22.19
[1/4] 🔍  Resolving packages...
success Already up-to-date.
✨  Done in 0.12s.
==> build-ui
yarn run v1.22.19
$ ts-node ./scripts/esbuild.ts

  dist/index.js     3.7mb ⚠️
  dist/index.css  125.4kb

✨  Done in 1.61s.
==> get-envoy
==> deps-build
==> deps-release
==> build-deps
==> build-go
==> build
➜  pomerium-3 git:(cdoxsey/lfs) ✗ git status
On branch cdoxsey/lfs
Your branch is up to date with 'origin/cdoxsey/lfs'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   ui/dist/index.css
        modified:   ui/dist/index.js

@calebdoxsey
Copy link
Contributor Author

I did. Maybe it's not deterministic. In which case the pre-commit hook I added isn't going to work.

@calebdoxsey
Copy link
Contributor Author

Pulled it down on mac and re-ran the build... it gave me the same files. I guess we can't rely on this build process. We will each end up committing a different build.

@calebdoxsey
Copy link
Contributor Author

Not doing this for now.

@calebdoxsey calebdoxsey deleted the cdoxsey/lfs branch May 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI/CD and release automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants