Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: add Tap http filter if configured #5043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

denniskniep
Copy link

Summary

If configured an tap http filter is added to the envoy config.
The added tap filter is configured for admin control and therefore available if the envoy admin endpoint is configured.

How to test

Prerequisite enable envoy admin endpoint via config:
envoy_admin_address: localhost:9901

Set config envoy_admin_enable_tap to true

and subscribe to the tap:

curl -X POST http://localhost:9901/tap -H "Content-Type: application/yaml" \
-d 'config_id: downstream
tap_config:
  match_config:
    any_match: true
  output_config:
    sinks:
      - format: JSON_BODY_AS_STRING
        streaming_admin: {}'

see also:

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

If configured an tap http filter is added.
The added tap filter is configured for admin control and
therefore available if the envoy admin interface is configured.
@denniskniep denniskniep requested a review from a team as a code owner March 29, 2024 14:03
@desimone
Copy link
Contributor

Thanks @denniskniep -- I know we covered this async, but would you mind filling out a corresponding feature request to capture the use case behind this addition? In general, we try to think super carefully about new configuration surface area so I'd love to bubble this up.

@denniskniep
Copy link
Author

@desimone I raised a corresponding feature request, see #5052

@desimone
Copy link
Contributor

desimone commented Apr 2, 2024

Thank you @denniskniep; will review next product planning session.

@desimone desimone added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. NeedsDiscussion labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants