Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check goreleaser options are still compatible #4490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Aug 29, 2023

Summary

goreleaser deprecated a lot of options and in general we don't want to be caught by a surprise during release process.

we will run a check once a month to see if we're compatible with latest goreleaser. if we're incompatible, we would have this action failing with details like

  • loading config file                              file=.github/goreleaser.yaml
  ⨯ command failed                                   error=yaml: unmarshal errors:
  line 269: field empty_folders not found in type config.NFPM
  line 292: field replacements not found in type config.NFPMOverridables

Related issues

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner August 29, 2023 15:15
@wasaga wasaga requested a review from kenjenkins August 29, 2023 15:15
@coveralls
Copy link

Coverage Status

coverage: 64.064%. remained the same when pulling a9fea52 on wasaga/goreleaser-check into 5a4acc5 on main.

Copy link
Contributor

@kenjenkins kenjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: how will we notice if this action fails?

Would it be possible for this action to file an issue if this check fails? I see there's a Create an Issue action. Could we use a conditional failure expression to file/update an issue if this check fails?

@wasaga
Copy link
Contributor Author

wasaga commented Aug 29, 2023

i think there's an email alert when action fails, but opening an issue might be nice indeed. not sure how to prevent duplicate issues being open each time the action runs though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants