Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dunstctl: script, module & preview images #362

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aidenlangley
Copy link

No description provided.

Copy link
Member

@x70b1 x70b1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Would you like to change the scripts so that they are not shell specific?

@aidenlangley
Copy link
Author

aidenlangley commented Jan 18, 2022

Sure, can include a sh version, will push it shortly.

@x70b1
Copy link
Member

x70b1 commented Feb 16, 2022

What about removing the fish version?

@M-Mabrouk1
Copy link

M-Mabrouk1 commented Mar 4, 2022

Thanks for that amazing script, But I noticed that the show-all not working with me because i wasn't having the jq package, just hilight that in the README.

@aidenlangley
Copy link
Author

What about removing the fish version?

Why?

@x70b1
Copy link
Member

x70b1 commented Mar 7, 2022

To not have to maintain 2 versions of the script.

@aidenlangley
Copy link
Author

I'd prefer to keep them both, it's a good foundation for others to build on if they'd like to learn, and realistically, the scripts will not change often, and it's not that difficult to maintain them both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants