Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExpressVPN on Build && Documentation Updates #52

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mindovermiles262
Copy link

@mindovermiles262 mindovermiles262 commented Oct 26, 2023

  • Updated the expressvpn-transmission README to include a wildcard accept IP address example.

  • Updated expressvpn Dockerfile to upgrade expressvpn during build. Removes the need to hardcode the latest version of expressvpn into the Dockerfile

  • Added an example docker-compose file to make things easier and more repeatable to run

Signed-off-by: Andrew <mindovermiles262@gmail.com>
…w IP addresses

Signed-off-by: Andrew <mindovermiles262@gmail.com>
Signed-off-by: Andrew <mindovermiles262@gmail.com>
Signed-off-by: Andrew <mindovermiles262@gmail.com>
Signed-off-by: Andrew <mindovermiles262@gmail.com>
polkaned
polkaned previously approved these changes Nov 19, 2023
@polkaned
Copy link
Owner

I would like to approuve commit by commit, but I can't.
Please, can you make 2 PR: one for the documentation and docker compose example, and another one for the expressvpn upgrade functionality?
I miss the functionality of self upgrade. But, I not sure it is want we want.
We want to know the version (to rollback for exemple).
However, we can let the user to decide: so implement conditional.
For example:

  • Set a new ARG AUTO_UPGRADE=0
  • Add a second RUN if AUTO_UPGRADE=1 and run update, upgrade and clean.
  • When you want to build a image with auto upgrade, set AUTO_UPGRADE=1 at the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants